-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Missing semicolon in Console Component example #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s / isStoppedPropagation / isPropagationStopped()
Tidying up some DI related terminology
Adding info on twig:lint console command
Adding info on router:match command
…_name Updated cookbook title to match the usual format and added index entries
updated documentation for the profiler usage in a functional test
Conflicts: cookbook/doctrine/event_listeners_subscribers.rst
[2.2] [Validator] Luhn Validator
Conflicts: components/map.rst.inc
This looks funny to me... shouldn't this be an adverb (I'm not sure, I'm not a native english speaker)?
Conflicts: components/routing.rst
The code is neater if we use the dedicated method available in the Request class
field_label, field_widget, field_errors and fields_row are deprecated in sf 2.1
Conflicts: book/templating.rst
Conflicts: cookbook/form/form_collections.rst
Conflicts: cookbook/form/form_collections.rst
- Added a link to Packagist - Removed PEAR link
Improved Form Validation Docs
…raints` option on individual forms, which is much easier than adding things globally, as we did in 2.0
[Component][Filesystem] Changed installation chapter
…nts-reference [Reference][Constraints]Added missing xml configuration examples for validation constraints
Conflicts: reference/constraints/All.rst reference/constraints/Country.rst reference/constraints/Date.rst reference/constraints/Ip.rst reference/constraints/Language.rst reference/constraints/Locale.rst reference/constraints/Time.rst reference/constraints/Type.rst reference/constraints/Url.rst
This is already waiting for merge in #2084 |
Hi Carlos! This is a good fix, but it's a duplicate as @wouterj said. But thanks for the contribution - we appreciate you looking for errors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.